Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conda detection #55

Merged
merged 9 commits into from
Jun 26, 2024
Merged

Fix conda detection #55

merged 9 commits into from
Jun 26, 2024

Conversation

DonJayamanne
Copy link
Collaborator

No description provided.

@DonJayamanne DonJayamanne changed the title Fix conta detection Fix conda detection Jun 26, 2024
@DonJayamanne DonJayamanne marked this pull request as ready for review June 26, 2024 03:17
@vscodenpa vscodenpa added this to the June 2024 milestone Jun 26, 2024
@DonJayamanne DonJayamanne enabled auto-merge (squash) June 26, 2024 03:59
// Making this the top level container so it works on codespaces,
// Cannot always use locally as this is only x64 compatible
"name": "codespaces-jupyter",
"image": "mcr.microsoft.com/devcontainers/universal:2",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a dev container for testing of this scenario identified

@@ -38,7 +38,7 @@ clap = { version = "4.5.4", features = ["derive", "cargo"] }
serde = { version = "1.0.152", features = ["derive"] }
serde_json = "1.0.93"

[dev_dependencies]
[dev-dependencies]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New format is dev-depdencies

@DonJayamanne DonJayamanne merged commit b710945 into main Jun 26, 2024
24 checks passed
@DonJayamanne DonJayamanne deleted the fixContaDetection branch June 26, 2024 04:08
@karthiknadig karthiknadig added the bug Issue identified by VS Code Team member as probable bug label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants