Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ignoreSync #9105

Closed
wants to merge 1 commit into from
Closed

feat: ignoreSync #9105

wants to merge 1 commit into from

Conversation

Malix-Labs
Copy link

@Malix-Labs Malix-Labs commented Sep 28, 2024

Closes microsoft/pylance-release#6474

This is an appending to a bulk, it might be to wide, please see each line as an individual review

Related

@Malix-Labs
Copy link
Author

@microsoft-github-policy-service agree

@Malix-Labs
Copy link
Author

Malix-Labs commented Sep 28, 2024

@erictraut why ?

Note :

This is an appending to a bulk, it might be to wide, please see each line as an individual review

Also, it was a draft PR and not marked as ready for review

@Malix-Labs Malix-Labs changed the title feat: ignoreSync feat: ignoreSync Sep 28, 2024
@erictraut
Copy link
Collaborator

@Malix-Labs, I assumed this PR was created in error. There was no context about what it was attempting to do, and its contents didn't make sense to me. I presume that your intent was to check in a change to your own fork but not create a PR to the main pyright fork.

If you're interested in suggesting a new feature in pyright, I recommend that you start by posting an enhancement request and/or a discussion topic to get feedback on the feature.

@Malix-Labs
Copy link
Author

Malix-Labs commented Sep 28, 2024

If you're interested in suggesting a new feature in pyright, I recommend that you start by posting an enhancement request and/or a discussion topic to get feedback on the feature.

Right ;

Done, see microsoft/pylance-release#6474 !

@Malix-Labs
Copy link
Author

I couldn't find the difference between ignoreSync and the "machine" scope, so I will first wait for vscode's clarification (see microsoft/vscode-docs#7638)

Consider as draft (not ready for review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ignoreSync for path settings element
2 participants