Jacdac cherry pick #10887
Open
Jacdac cherry pick #10887
+87
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* if we get jacdac packet over webusb, always send up * well, this too
* special case for second main simulator * split line * add a comment about the logic * just check as boolean
* generalize * updates * remove whitespace * deal with mono repo * cleanup * simplify form * get version tag * correct format issues * correct bad async call * remove whitespace * more fixes --------- Co-authored-by: Abhijith Chatra <[email protected]>
|
This is larger change than I anticipated and will require proper testing. I would like to wait on it till the team is back on Arcade to release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
picking commits needed for moving to new jacdac