A few blockly tutorial fixes #10384
Merged
A few blockly tutorial fixes #10384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
each commit is a different fix!
fixes microsoft/pxt-arcade#6630
the issue here was that the min/max properties on the field were unset, which was causing it fail to parse values passed in as the default
fixes microsoft/pxt-arcade#6643
this issue was that we weren't busting the flyout cache properly for tutorials where the contents of a flyout can change for each step
fixes microsoft/pxt-arcade#6627
there are a ton of different ways to decompile to the tileset field and each one has slightly different syntax. adding a fallback case to the if statement that just tries to find the asset by name even if the value passed in isn't in the full asset reference format