Align new project skip link behaviour with new project button #10382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microbit-robert
commented
Feb 12, 2025
webapp/src/app.tsx
Outdated
| @@ -2914,6 +2914,18 @@ export class ProjectView | |||
| }); | |||
| } | |||
|
|
|||
| newProjectMaybeWithProjectCreationOptions(firstProject: boolean) { | |||
There was a problem hiding this comment.
We'd absolutely welcome a better name for this method. An alternative could be just to duplicate this code in both accessibility.tsx and projects.tsx in their own newProject methods that then call this.props.parent.newProject. The latter approach does make it more likely that this bug will reoccur if a new entry point (button) to create a new project is introduced in the app.
There was a problem hiding this comment.
oh yeah, that one's a mouthful... perhaps newUserCreatedProject? would also be nice to convert this into async/await while you're here
There was a problem hiding this comment.
That sounds good. Both changes made here aea20a3.
riknoll
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new project skip link on the home page launches a new project without showing the "Create a Project" dialog (if available depending on the
appThemesettings) where as the "New Project" button does. This PR aligns these behaviours.@microbit-matt-hillsdon