OCV: add support for high contrast toggling #10377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eanders-ms
approved these changes
Feb 8, 2025
| @@ -129,17 +130,17 @@ const getIFrameAndSend = (payload: FeedbackResponsePayloadType) => { | |||
| // TODO | |||
There was a problem hiding this comment.
Can this TODO comment be deleted now?
thsparks
approved these changes
Feb 10, 2025
| @@ -48,10 +48,12 @@ type FeedbackResponsePayloadType = { | |||
| data: FeedbackResponseDataType | |||
| } | |||
|
|
|||
| const defaultTheme = "PublisherLightTheme"; | |||
| const highContrastTheme = "PublisherDarkTheme"; | |||
There was a problem hiding this comment.
As a curiosity, do they document this as an actual high contrast theme? Or just as a dark theme?
There was a problem hiding this comment.
No, just a dark theme. I just saw the teams high contrast one. I will use that one instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says, this makes it so when we switch to high contrast, we use a high contrast/dark themed version of OCV.
This is what it looks like toggled on:
(Image updated)