Fix keyboard navigation for the dropdown menu component #10369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microbit-robert
commented
Feb 5, 2025
| // Check if item is intended for mobile only views | ||
| if (pxt.BrowserUtils.containsClass(child, "mobile") && !pxt.BrowserUtils.isMobile()) continue; | ||
| // Check if item is visible. Some items are intended for mobile only views. | ||
| if (!child.offsetParent) continue; |
There was a problem hiding this comment.
We considered using checkVisibility() here, but this appears to be too recent for the tsconfig settings.
|
@microsoft-github-policy-service agree company="Micro:bit Educational Foundation" |
riknoll
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following bugs in keyboard handling for the dropdown menu component:
componentDidMount. Any items that are added aftercomponentDidMount(such as "Connect Device" in the settings menu) do not get key handling.getChildrenchecks for mobile viauserAgentand not whether the menu item is visible based on screen width.All key handling has been moved up to the parent dropdown to address the first bug and the use of
offsetParentreplaces the call topxt.BrowserUtils.isMobile()to address the second bug. This PR maintains the existing keyboard and mouse behaviour except for focussing the first menu item when the menu is opened via the keyboard using "Enter" or "Space" which is considered best practice.This screen recording demonstrates both bugs:
https://github.com/user-attachments/assets/76c7d84c-5e48-42cd-a6be-43a9c67a00b9
@microbit-matt-hillsdon