need to start the simulator after create to avoid race #10349
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A very infrequent race condition occurs where the extension's simulator appears and the micro:bit simulator never appears. This is very curious, as the extension simulator can only be invoked by static typescript (user-level code), which must be executing, which should bring up the micro:bit simulator. The problem is that the start function of simulatorDriver does not start the simulator in the case when it is being created the first time. Most often, some other path then creates the simulator, and the start function is called, which does start the simulator. But this change ensures the the micro:bit simulator will always appear first.