Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links inside docs page after staticpkg are broken #4717

Closed
dwaw18 opened this issue Sep 24, 2018 · 3 comments
Closed

Links inside docs page after staticpkg are broken #4717

dwaw18 opened this issue Sep 24, 2018 · 3 comments

Comments

@dwaw18
Copy link

dwaw18 commented Sep 24, 2018

Describe the bug
After running staticpkg, attempt to navigate inside docs page fails (404 - page not found).

To Reproduce
Steps to reproduce the behavior:

  1. Run pxt staticpkg and http-server -c-1 built/packaged in custom pxt target
  2. Go to http://localhost:8080/docs/blocks/loops.html
  3. Click on any of present blocks.
  4. See 404 error - page not found.

Expected behavior
Docs about given block should be displayed properly.

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: Google Chrome
  • Version: 69.0.3497.100

Additional context

  • pxt-core version: 4.0.5
  • When directly opening http://localhost:8080/docs/blocks/loops/for.html, page is displayed correctly.
  • To my understanding, only links associated to blocks are broken, because when I click on for link in See also section, page is displayed properly. Navigating through left=hand side menu also seems to work fine.
@FranklinWhale
Copy link
Contributor

May be related to #4700 (comment)

@guillaumejenkins
Copy link
Contributor

This should have been fixed by #4704

@guillaumejenkins guillaumejenkins removed their assignment Oct 4, 2018
@dwaw18
Copy link
Author

dwaw18 commented Oct 5, 2018

There is definitely an improvement, but for example clicking on for block in loops category is still causing a 404 error.
ezgif-2-ea197f544160

@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants