Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference and Blocks cannot be loaded after staticpkg #4700

Closed
FranklinWhale opened this issue Sep 20, 2018 · 3 comments · Fixed by #4704
Closed

Reference and Blocks cannot be loaded after staticpkg #4700

FranklinWhale opened this issue Sep 20, 2018 · 3 comments · Fixed by #4704
Assignees

Comments

@FranklinWhale
Copy link
Contributor

Describe the bug
After staticpkg, the Reference and Blocks options under the Help menu in the Editor do not work properly. The "open in new tab" link of each option opens http://host/docs/docs/reference.html and http://host/docs/docs/blocks.html respectively. The "docs" is duplicated.

To Reproduce
Steps to reproduce the behavior:

  1. Run pxt staticpkg in a pxt target
  2. Serve the folder of the packaged files in a webserver and open it in browser using HTTP
  3. Open a project in Makecode
  4. Select Reference or Blocks in the Help menu (the "?")

Expected behavior
The reference or blocks info should be displayed

Screenshots
image

@guillaumejenkins
Copy link
Contributor

I am seeing this in the Electron app too, looks like this is a recent regression

@FranklinWhale
Copy link
Contributor Author

@guillaumejenkins I think #4704 may not have fully fixed this issue. After #4704, the Blocks option now works:

image

Unfortunately, the "open in new tab" link continues to point to http://127.0.0.1:8080/docs/docs/blocks.html.

Also, the Reference option and its "open in new tab" remain broken:

image

Would you re-open this issue? Thanks.

@lock
Copy link

lock bot commented Sep 25, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants