Skip to content

Added missing RGB_24bpp Image visualizer for PsiStudio #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 23, 2021
Merged

Added missing RGB_24bpp Image visualizer for PsiStudio #171

merged 2 commits into from
Jun 23, 2021

Conversation

xiangzhi
Copy link
Contributor

@xiangzhi xiangzhi commented Jun 22, 2021 •
edited
Loading

  • Added the missing RGB_24bpp image visualizer
  • Added extra check when updating bitmap for when the image is null due to unknown pixel format.

Thanks to Victor Del Carpio Gomez for spotting this error when using our ROS Bag reader.

@danbohus danbohus requested a review from chitsaw June 22, 2021 20:30
chitsaw
chitsaw approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@chitsaw chitsaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@chitsaw chitsaw merged commit 3fe655a into microsoft:master Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@chitsaw chitsaw chitsaw approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xiangzhi @chitsaw