-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial changes for VSCode.dev WebExtension for Portals #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashishchoudhary001
requested review from
ameyaapte1,
davidjenni,
joaomoreno and
vedg
May 25, 2022 14:27
ameyaapte1
approved these changes
May 27, 2022
ameyaapte1
reviewed
May 27, 2022
joaomoreno
approved these changes
May 31, 2022
davidjenni
requested changes
Jun 7, 2022
tehcrashxor
reviewed
Jun 8, 2022
tehcrashxor
reviewed
Jun 10, 2022
tehcrashxor
reviewed
Jun 13, 2022
tehcrashxor
reviewed
Jun 14, 2022
davidjenni
approved these changes
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the existing extension to serve as both desktop + web extension
Guidelines for the changes: https://code.visualstudio.com/api/extension-guides/web-extensions#update-existing-extensions-to-web-extensions
dist file/folder structure:
fcb for webExtension:
disabling commands in virtualWorkspace:
https://code.visualstudio.com/api/extension-guides/virtual-workspaces