ECS Initialization fix for desktop on Org Switch #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyaginidhi
approved these changes
Sep 11, 2024
sanxsth
approved these changes
Sep 11, 2024
amitjoshi438
deleted the
users/amitjoshi/desktopEcsInitializationFix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve the functionality and maintainability of the codebase. The key modifications involve reordering code for better readability, adding a new parameter to a function call, and updating method signatures to include an optional
forceparameter.Code reordering and readability improvements:
src/client/extension.ts: Moved theworkspaceFoldersinitialization to a more appropriate location for better readability. [1] [2]Function call updates:
src/client/extension.ts: Added atrueparameter to thePowerPagesClientNamefunction call to enable a new feature.Method signature updates:
src/common/ecs-features/ecsFeatureClient.ts: Updated theinitmethod inECSFeaturesClientto include an optionalforceparameter, allowing forced reinitialization.