Fix CWE-789: Uncontrolled Memory Allocation by changing malloc to calloc#348
Closed
kayAlPal wants to merge 1 commit intomicrosoft:masterfrom
Closed
Fix CWE-789: Uncontrolled Memory Allocation by changing malloc to calloc#348kayAlPal wants to merge 1 commit intomicrosoft:masterfrom
kayAlPal wants to merge 1 commit intomicrosoft:masterfrom
Conversation
Author
|
@microsoft-github-policy-service agree |
Contributor
|
We do not plan to release a new version of PLCrashReporter. If you require these changes, please apply them in your own fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things to consider before you submit the PR:
CHANGELOG.mdbeen updated?Description
The goal of the pull-request is to fix an error that the application received, that it uses malloc instead of calloc. It is fixed now in the application, but it would be nice if it could be fixed in plcrashreporter as well.
Related PRs or issues
None
Misc
In a bit of a hurry. The unit tests failed when on master and the sample apps didn't do too much better. Have not had time to chase down why.