Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce ember selector engine #8444

Closed
wants to merge 1 commit into from

Conversation

lifeart
Copy link

@lifeart lifeart commented Aug 25, 2021

refs: https://github.com/microsoft/playwright/pull/8070/files

Should work for Ember starting from 3.14.0, debug API introduced in Debug Render Tree (for Ember Inspector)

How to get it working in prod env

To do:

This is how /tests/assets/reading-list/ember3.html looks in ember-inspector

image

Ember Inspector Extension

If Ember Inspector is not working for file:// url's

  • Visit the URL: chrome://extensions.
  • Find the Ember Inspector (chrome://extensions/?id=bmdblncegkenkacieihfhpjfppoconhi)
  • Make sure "Allow access to file URLs" is checked.

@ghost
Copy link

ghost commented Aug 25, 2021

CLA assistant check
All CLA requirements met.

@lifeart lifeart marked this pull request as ready for review August 25, 2021 22:51
@lifeart lifeart force-pushed the ember-selector-engine branch 2 times, most recently from 5973149 to 03e3357 Compare August 26, 2021 10:59
@aslushnikov
Copy link
Contributor

aslushnikov commented Aug 30, 2021

Hey @lifeart,

We have no ember experts on the team right now 🤷‍♂️. Could you publish this as a plugin for now? Selector engines could be registered with selectors.register method.

P.S. PR itself looks awesome! We just aren't ready to commit to maintaining it inside this source base.

@lifeart
Copy link
Author

lifeart commented Aug 30, 2021

Hi @aslushnikov! Thank you for feedback! Any chance to get functions from

import { checkComponentAttribute, parseComponentSelector } from '../common/componentUtils';

as a part of public playwright API?

Now it's not bundled for it:

@aslushnikov
Copy link
Contributor

aslushnikov commented Aug 30, 2021

@lifeart Even if we expose it, we won't be able to guarantee that these methods won't change in future, so relying on them is risky.

I'd just copy them into your source!

@lifeart
Copy link
Author

lifeart commented Aug 30, 2021

@aslushnikov, thank you! Closing MR for now.

@lifeart lifeart closed this Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants