chore: do not log process not found warning on win when PID is not found #7500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
force-pushed
the
bugfix/taskkill-do-not-error-if-non-existent
branch
from
f9a78a7 to
19086fc
Compare
mxschmitt
force-pushed
the
bugfix/taskkill-do-not-error-if-non-existent
branch
from
19086fc to
6fe0484
Compare
yury-s
approved these changes
Jul 7, 2021
dgozman
added a commit
to dgozman/playwright
that referenced
this pull request
Apr 7, 2022
This was introduced in microsoft#7500 to fight `ERROR: The process "4436" not found.` messages when killing a process that did already exit. Since then, we no longer inherit stdout/stderr, so the error message should not appear anymore.
dgozman
added a commit
that referenced
this pull request
Apr 8, 2022
This was introduced in #7500 to fight `ERROR: The process "4436" not found.` messages when killing a process that did already exit. Since then, we no longer inherit stdout/stderr, so the error message should not appear anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filtering by status is not possible (
STATUS eq RUNNING) when using/Twhich will kill the whole process tree which was my first attempt. Usinghaving a memory usage of > 0as a workaround, see here.Fixes #7456
Fixes these warnings on the bots too https://github.com/microsoft/playwright/runs/3005351152#step:7:16