-
Notifications
You must be signed in to change notification settings - Fork 5k
chore(mcp): let browser_run_code support helper scripts #38730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"3 fatal errors, not part of any test 3 flaky34188 passed, 691 skipped Merge workflow run. |
Test results for "MCP"1 failed 2842 passed, 121 skipped Merge workflow run. |
| `); | ||
|
|
||
| const code = `async (page) => { | ||
| const { clickSubmit } = await import(${JSON.stringify(scriptPath)}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we want to prohibit random imports? Looks like it did work for require but not for import. I think the user should have better control over what can be imported.
| "@types/codemirror": "^5.60.7", | ||
| "@types/formidable": "^2.0.4", | ||
| "@types/node": "18.19.76", | ||
| "@types/node": "25.0.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use 20 which is our oldest supported node?
https://platform.claude.com/docs/en/agents-and-tools/agent-skills/best-practices#provide-utility-scripts
This API is experimental, though. https://nodejs.org/api/vm.html#support-of-dynamic-import-in-compilation-apis