feat: --pause #38338
feat: --pause #38338
Conversation
| onTestBegin?(test: TestCase, result: TestResult): void; | ||
| onStdOut?(chunk: string | Buffer, test?: TestCase, result?: TestResult): void; | ||
| onStdErr?(chunk: string | Buffer, test?: TestCase, result?: TestResult): void; | ||
| onTestPaused?(test: TestCase, result: TestResult): void; |
There was a problem hiding this comment.
I played around with different variants of invoking the reporter. A special function ended being the easiest to reason about. This should probably replace FailureTracker#onTestPaused.
| return; | ||
| } | ||
|
|
||
| if (data.apiName === 'page.pause' && data.frames.length === 0 && channel.params?.location) |
There was a problem hiding this comment.
this is hella hacky. i'm all ears for a better solution
| return true; | ||
| } | ||
|
|
||
| export function findTestEndPosition(text: string, location: Location): Location | undefined { |
There was a problem hiding this comment.
I'm not sure at what time we already parse the test code. Potentially we could do this at scanning time, and then the Extension could get the end position from the Reporter API?
|
|
||
| export type ConfigCLIOverrides = { | ||
| debug?: boolean; | ||
| pause?: boolean; |
There was a problem hiding this comment.
This could replace new TestRun(options=)
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Test results for "MCP"3 failed 1 flaky2606 passed, 116 skipped Merge workflow run. |
Test results for "tests 1"1 failed 9 flaky40307 passed, 787 skipped Merge workflow run. |
|
superceded by #38345 |
1 participant
No description provided.