chore: migrate proxy handling to WHATWG URL #37745
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #37713, part of #37676.
There's two main behaviour changes in WHATWG:
Invalid URLs throw an exception: When a proxy URL is missing protocols, we default it to HTTP. WHATWG by default throws an exception. To prevent that, i've extended our defaulting to the
httpRequest
routine. Picking HTTP as the default protocol is inline with our previous behaviour - the prior version of https-proxy-agent picked the protocol based onsecureProxy
, and we chosefalse
when there's no protocol defined. We also have lots of coverage on this inproxy.spec.ts
.Unspecified or default segments are represented as empty string: I'm assuming that
https-proxy-agent
knows how to handle that, so I haven't made any further changes.I also had my Copilot double-check the code and verify the behaviour changes.
Prompt