Skip to content

Conversation

matthewpango
Copy link
Contributor

some Android media keys are missing

This comment has been minimized.

Copy link
Member

@yury-s yury-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I there a real world use case where you need those? Usually we start with a bug/feature request describing the problem.

@matthewpango
Copy link
Contributor Author

I there a real world use case where you need those? Usually we start with a bug/feature request describing the problem.

I work with Android TV/STB devices where these media keys are essential for testing media applications. I understand the process now and will create an issue first for future contributions.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

Test results for "tests 1"

2 failed
❌ [playwright-test] › update-aria-snapshot.spec.ts:669 › update-source-method › should overwrite source when specified in the config @macos-latest-node18-1
❌ [playwright-test] › reporter-html.spec.ts:724 › created › should warn user when viewing via file:// protocol @macos-latest-node18-2

6 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1079 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node18`
⚠️ [firefox-page] › page/page-event-request.spec.ts:182 › should return response body when Cross-Origin-Opener-Policy is set `@firefox-ubuntu-22.04-node18`
⚠️ [firefox-page] › page/page-goto.spec.ts:83 › should work with Cross-Origin-Opener-Policy `@firefox-ubuntu-22.04-node18`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:397 › should work behind reverse proxy `@macos-latest-node18-1`
⚠️ [webkit-library] › library/browsercontext-add-cookies.spec.ts:426 › should allow unnamed cookies `@webkit-ubuntu-22.04-node18`
⚠️ [webkit-library] › library/inspector/cli-codegen-pick-locator.spec.ts:35 › should update locator highlight `@webkit-ubuntu-22.04-node18`

46836 passed, 821 skipped


Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants