Skip to content

Conversation

Skn0tt
Copy link
Member

@Skn0tt Skn0tt commented Aug 22, 2025

Resolves #37147, which regressed in 5965db1. We're trying to report an attachment for a step that we skipped reporting, which leads to the error. The fix is to exclude the stepId when reporting the attachment.

@Skn0tt Skn0tt requested a review from dgozman August 22, 2025 12:50
Copy link
Contributor

Test results for "tests 1"

4 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1079 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node18`
⚠️ [firefox-page] › page/page-event-request.spec.ts:182 › should return response body when Cross-Origin-Opener-Policy is set `@firefox-ubuntu-22.04-node18`
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104 › should work with strict CSP policy `@firefox-ubuntu-22.04-node18`
⚠️ [playwright-test] › ui-mode-test-output.spec.ts:117 › should collapse repeated console messages for test `@macos-latest-node18-1`

46630 passed, 805 skipped


Merge workflow run.

@Skn0tt Skn0tt self-assigned this Aug 22, 2025
@Skn0tt Skn0tt merged commit 409d13f into microsoft:main Aug 26, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Regression]: Internal error: step id not found
2 participants