Skip to content

test: remove stale fixme/skips in capabilities spec #36617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mxschmitt merged 1 commit into from
Jul 9, 2025
Merged

test: remove stale fixme/skips in capabilities spec #36617

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 4 additions & 14 deletions tests/library/capabilities.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
* limitations under the License.
*/

import os from 'os';
import url from 'url';
import { contextTest as it, expect } from '../config/browserTest';
import { hostPlatform } from '../../packages/playwright-core/src/server/utils/hostPlatform';
Expand All @@ -31,8 +30,7 @@ it('SharedArrayBuffer should work @smoke', async function({ contextFactory, http
expect(await page.evaluate(() => typeof SharedArrayBuffer)).toBe('function');
});

it('Web Assembly should work @smoke', async ({ page, server, browserName, platform }) => {
it.fixme(browserName === 'webkit' && platform === 'win32', 'Windows JIT is disabled: https://bugs.webkit.org/show_bug.cgi?id=273854');
it('Web Assembly should work @smoke', async ({ page, server }) => {
await page.goto(server.PREFIX + '/wasm/table2.html');
expect(await page.evaluate('loadTable()')).toBe('42, 83');
});
Expand Down Expand Up @@ -101,20 +99,16 @@ it('should play audio @smoke', async ({ page, server, browserName, platform }) =
expect(await page.$eval('audio', e => e.currentTime)).toBeGreaterThan(0.2);
});

it('should support webgl @smoke', async ({ page, browserName, platform }) => {
it.fixme(browserName === 'chromium' && platform === 'darwin' && os.arch() === 'arm64', 'SwiftShader is not available on macOS-arm64 - https://github.com/microsoft/playwright/issues/28216');
it('should support webgl @smoke', async ({ page }) => {
const hasWebGL = await page.evaluate(() => {
const canvas = document.createElement('canvas');
return !!canvas.getContext('webgl');
});
expect(hasWebGL).toBe(true);
});

it('should support webgl 2 @smoke', async ({ page, browserName, headless, isWindows, platform }) => {
it.skip(browserName === 'webkit', 'WebKit doesn\'t have webgl2 enabled yet upstream.');
it('should support webgl 2 @smoke', async ({ page, browserName, isWindows }) => {
it.fixme(browserName === 'firefox' && isWindows);
it.fixme(browserName === 'chromium' && !headless, 'chromium doesn\'t like webgl2 when running under xvfb');
it.fixme(browserName === 'chromium' && platform === 'darwin' && os.arch() === 'arm64', 'SwiftShader is not available on macOS-arm64 - https://github.com/microsoft/playwright/issues/28216');

const hasWebGL2 = await page.evaluate(() => {
const canvas = document.createElement('canvas');
Expand All @@ -131,7 +125,6 @@ it('should not crash on page with mp4 @smoke', async ({ page, server, platform,

it('should not crash on showDirectoryPicker', async ({ page, server, browserName, browserMajorVersion }) => {
it.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/7339' });
it.skip(browserName === 'chromium' && browserMajorVersion < 99, 'Fixed in Chromium r956769');
it.skip(browserName !== 'chromium', 'showDirectoryPicker is only available in Chromium');
await page.goto(server.EMPTY_PAGE);
// "User activation is required to show a file picker." - so we click first.
Expand All @@ -148,7 +141,6 @@ it('should not crash on showDirectoryPicker', async ({ page, server, browserName

it('should not crash on storage.getDirectory()', async ({ page, server, browserName, isMac }) => {
it.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/18235' });
it.skip(browserName === 'firefox', 'navigator.storage.getDirectory is not a function');
await page.goto(server.EMPTY_PAGE);
const error = await page.evaluate(async () => {
const dir = await navigator.storage.getDirectory();
Expand Down Expand Up @@ -281,7 +273,6 @@ it('should send no Content-Length header for GET requests with a Content-Type',

it('Intl.ListFormat should work', async ({ page, server, browserName }) => {
it.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/23978' });
it.skip(browserName === 'webkit' && hostPlatform.startsWith('ubuntu20.04'), 'libicu is too old and WebKit disables Intl.ListFormat by default then');
await page.goto(server.EMPTY_PAGE);
const formatted = await page.evaluate(() => {
const data = ['first', 'second', 'third'];
Expand Down Expand Up @@ -434,8 +425,7 @@ it('should not crash when clicking a color input', {
type: 'issue',
description: 'https://github.com/microsoft/playwright/issues/33864'
}
}, async ({ page, browserMajorVersion, browserName }) => {
it.skip(browserName === 'firefox' && browserMajorVersion < 135);
}, async ({ page }) => {

await page.setContent('<input type="color">');
const input = page.locator('input');
Expand Down
Loading