Skip to content

Conversation

@dgozman
Copy link
Contributor

@dgozman dgozman commented Jul 1, 2025

  • Do not allow two clients to route simultaneously.
  • Cleanup after dispatcher disconnects.
  • Ensure that routing works in context reuse scenarios.
  • Test context reuse both in the launched browser with a single connection, and in a connected browser with different connections.

Fixes #36480. References #35987.

@dgozman dgozman requested a review from yury-s July 1, 2025 13:23
@github-actions

This comment has been minimized.

@dgozman dgozman force-pushed the fix-web-socket-route branch from 5e0d92e to 1568220 Compare July 6, 2025 09:44
@github-actions

This comment has been minimized.

@dgozman dgozman requested a review from mxschmitt July 6, 2025 14:38
- Do not allow two clients to route simultaneously.
- Cleanup after dispatcher disconnects.
- Ensure that routing works in context reuse scenarios.
- Test context reuse both in the launched browser with a single
  connection, and in a connected browser with different
  connections.
@dgozman dgozman force-pushed the fix-web-socket-route branch from 1568220 to 4680bab Compare July 7, 2025 14:48
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2025

Test results for "tests 1"

8 flaky ⚠️ [chromium-library] › library/chromium/tracing.spec.ts:49:3 › should run with custom categories if provided @chromium-ubuntu-22.04-node20
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1087:7 › cli codegen record › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
⚠️ [firefox-page] › page/page-event-request.spec.ts:182:3 › should return response body when Cross-Origin-Opener-Policy is set @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @ubuntu-latest-node18-1
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @ubuntu-latest-node22-1
⚠️ [webkit-library] › library/inspector/pause.spec.ts:74:5 › pause › should pause and resume the script with keyboard shortcut @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

47188 passed, 980 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Regression. The routeWebSocket does not work on subsequent attempts unless the browser window is closed.

3 participants