chore: allow matching aria children strictly #35481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yury-s
previously approved these changes
Apr 3, 2025
dgozman
reviewed
Apr 3, 2025
pavelfeldman
force-pushed
the
match_structure
branch
from
b8e6814 to
485e780
Compare
dgozman
previously approved these changes
Apr 3, 2025
|
|
||
| // Proceed based on the container mode. | ||
| if (template.containerMode === 'contain') | ||
| return containsList(node.children || [], template.children || []); |
There was a problem hiding this comment.
If we had a parent with deepEqual, should we inherit that to our grandchildren, i.e. only opt-out this particular node? As implemented, setting contain resets deep-equal for the whole subtree. Perhaps deep-contain is justified?
There was a problem hiding this comment.
I'd say they need to opt into deep equal again for that. That way you only need to climb to the nearest directive to understand the policy.
pavelfeldman
force-pushed
the
match_structure
branch
from
485e780 to
78a61ca
Compare
yury-s
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35158