chore: restore to.have.url matching via injected script #35027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgozman
approved these changes
Mar 4, 2025
Test results for "tests 1"1 failed 3 flaky38643 passed, 793 skipped Merge workflow run. |
agg23
added a commit
to agg23/playwright
that referenced
this pull request
Mar 4, 2025
dgozman
pushed a commit
to dgozman/playwright
that referenced
this pull request
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restores some of the code present before #34413, so language ports can continue handling
toHaveURLin the same way while still testing against it in JS. Now only the predicate goes through the new code path.