chore(ui): decouple TestServerConnection from websocket transport #32274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgozman
reviewed
Aug 22, 2024
| @@ -19,6 +19,16 @@ import * as events from './events'; | |||
|
|
|||
| // -- Reuse boundary -- Everything below this line is reused in the vscode extension. | |||
|
|
|||
| export interface TestServerSocket { | |||
There was a problem hiding this comment.
- We usually call things like this one "Transport" for easier search across the codebase.
- This is a somewhat convoluted interface for a transport. Perhaps we should separate transport (onmessage, onclose, send, close) from a factory that creates a websocket transport (this one needs open/error/etc).
There was a problem hiding this comment.
Sounds good! How do you like 0f37e55?
Meir017
reviewed
Aug 22, 2024
| @@ -102,7 +102,7 @@ export const WorkbenchLoader: React.FunctionComponent<{ | |||
| const guid = new URLSearchParams(window.location.search).get('ws'); | |||
| const wsURL = new URL(`../${guid}`, window.location.toString()); | |||
| wsURL.protocol = (window.location.protocol === 'https:' ? 'wss:' : 'ws:'); | |||
| const testServerConnection = new TestServerConnection(wsURL.toString()); | |||
| const testServerConnection = new TestServerConnection(new WebSocket(wsURL)); | |||
There was a problem hiding this comment.
const guid = new URLSearchParams(window.location.search).get('ws');
const wsURL = new URL(`../${guid}`, window.location.toString());
wsURL.protocol = (window.location.protocol === 'https:' ? 'wss:' : 'ws:');
const testServerConnection = new TestServerConnection(new WebSocket(wsURL));this code is also used in packages/trace-viewer/src/ui/uiModeView.tsx consider extracting to a utility function
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
dgozman
approved these changes
Aug 23, 2024
Test results for "tests 1"1 flaky30097 passed, 870 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation for #32076.