chore: print the launch error message to console #2304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelfeldman
force-pushed
the
timeout1
branch
3 times, most recently
from
f5500df to
8ef11e7
Compare
dgozman
reviewed
May 20, 2020
src/server/browserServer.ts
Outdated
| super(); | ||
| this._launchOptions = options; | ||
| this._logger = new RootLogger(options.logger); | ||
| this._launchDeadline = TimeoutSettings.computeDeadline(options.timeout || 30000); |
There was a problem hiding this comment.
This does not respect timeout: 0. You should only convert undefined into 30000.
src/server/browserServer.ts
Outdated
| return result; | ||
| } catch (e) { | ||
| await this._closeOrKill(deadline); | ||
| logPolitely('=============== Process output during launch: ===============\n' + |
There was a problem hiding this comment.
Why not add this to the error message instead? This way all the tooling and test runners will pick it up.
There was a problem hiding this comment.
I could do that, but strictly speaking there is an exception message and I don't want to alter it.
dgozman
approved these changes
May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2298