Skip to content

cherry-pick(#12888): fix(click): workaround elementsFromPoint issue in Chromium #12925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgozman merged 1 commit into from
Mar 21, 2022
Merged

cherry-pick(#12888): fix(click): workaround elementsFromPoint issue in Chromium #12925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/playwright-core/src/server/injected/injectedScript.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -804,8 +804,11 @@ export class InjectedScript {
while (container) {
// elementFromPoint works incorrectly in Chromium (http://crbug.com/1188919),
// so we use elementsFromPoint instead.
const elements = (container as Document).elementsFromPoint(x, y);
const innerElement = elements[0] as Element | undefined;
const elements: Element[] = container.elementsFromPoint(x, y);
let innerElement = elements[0] as Element | undefined;
// Workaround https://bugs.chromium.org/p/chromium/issues/detail?id=1307458.
if (elements[0] && elements[1] && elements[0].contains(elements[1]) && container.elementFromPoint(x, y) === elements[1])
innerElement = elements[1];
if (!innerElement || element === innerElement)
break;
element = innerElement;
Expand Down
59 changes: 59 additions & 0 deletions tests/hit-target.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,3 +184,62 @@ it('should work with drag and drop that moves the element under cursor', async (
await page.dragAndDrop('#from', '#to');
await expect(page.locator('#to')).toHaveText('Dropped');
});

it('should work with block inside inline', async ({ page, server }) => {
await page.goto(server.EMPTY_PAGE);
await page.setContent(`
<div>
<span>
<div id="target" onclick="window._clicked=true">
Romimine
</div>
</span>
</div>
`);
await page.locator('#target').click();
expect(await page.evaluate('window._clicked')).toBe(true);
});

it('should work with block-block-block inside inline-inline', async ({ page, server }) => {
await page.goto(server.EMPTY_PAGE);
await page.setContent(`
<div>
<a href="#ney">
<div>
<span>
<a href="#yay">
<div>
<h3 id="target">
Romimine
</h3>
</div>
</a>
</span>
</div>
</a>
</div>
`);
await page.locator('#target').click();
await expect(page).toHaveURL(server.EMPTY_PAGE + '#yay');
});

it('should work with block inside inline in shadow dom', async ({ page, server }) => {
await page.goto(server.EMPTY_PAGE);
await page.setContent(`
<div>
</div>
<script>
const root = document.querySelector('div');
const shadowRoot = root.attachShadow({ mode: 'open' });
const span = document.createElement('span');
shadowRoot.appendChild(span);
const div = document.createElement('div');
span.appendChild(div);
div.id = 'target';
div.addEventListener('click', () => window._clicked = true);
div.textContent = 'Hello';
</script>
`);
await page.locator('#target').click();
expect(await page.evaluate('window._clicked')).toBe(true);
});