feat(test-runner): introduce pixelCount and pixelRatio options
#12169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslushnikov
force-pushed
the
introduce-pixel-delta-option
branch
from
f0df752
to
2aec948
Compare
aslushnikov
commented
Feb 17, 2022
aslushnikov
force-pushed
the
introduce-pixel-delta-option
branch
from
2aec948
to
a31d56e
Compare
dgozman
approved these changes
Feb 17, 2022
This patch adds additional options to `toMatchSnapshot` method: - `pixelCount` - acceptable number of pixels that differ to still consider images equal. - `pixelRatio` - acceptable percentage of pixels that differ to still consider images equal. Since some anti-aliasing artifacts still can cripple in, we default `pixelCount` to some arbitrary small number - `17` - to improve tolerance. Fixes microsoft#12167, microsoft#10219
aslushnikov
force-pushed
the
introduce-pixel-delta-option
branch
from
54c809b
to
9a9091a
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds additional options to
toMatchSnapshotmethod:pixelCount- acceptable number of pixels that differ to stillconsider images equal, unset by default.
pixelRatio- acceptable percentage of pixels that differ to stillconsider images equal, unset by default.
Fixes #12167, #10219