chore(bidi): mark test expected to timeout as fixme (#34176)

microsoft · Dec 31, 2024 · 7769010 · 7769010
1 parent b2cbe7f
commit 7769010
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 6 deletions.
diff --git a/tests/bidi/csvReporter.ts b/tests/bidi/csvReporter.ts
@@ -45,15 +45,21 @@ class CsvReporter implements Reporter {
     for (const project of this._suite.suites) {
       for (const file of project.suites) {
         for (const test of file.allTests()) {
-          if (test.ok())
+          // Report fixme tests as failing.
+          const fixme = test.annotations.find(a => a.type === 'fixme');
+          if (test.ok() && !fixme)
             continue;
           const row = [];
           row.push(csvEscape(`${file.title} :: ${test.title}`));
           row.push(test.expectedStatus);
           row.push(test.outcome());
-          const result = test.results.find(r => r.error);
-          const errorMessage = stripAnsi(result?.error?.message.replace(/\s+/g, ' ').trim().substring(0, 1024));
-          row.push(csvEscape(errorMessage ?? ''));
+          if (fixme) {
+            row.push('fixme' + (fixme.description ? `: ${fixme.description}` : ''));
+          } else {
+            const result = test.results.find(r => r.error);
+            const errorMessage = stripAnsi(result?.error?.message.replace(/\s+/g, ' ').trim().substring(0, 1024));
+            row.push(csvEscape(errorMessage ?? ''));
+          }
           rows.push(row);
         }
       }

diff --git a/tests/config/browserTest.ts b/tests/config/browserTest.ts
@@ -188,8 +188,7 @@ const test = baseTest.extend<BrowserTestTestFixtures, BrowserTestWorkerFixtures>
   }, { scope: 'worker' }],
 
   autoSkipBidiTest: [async ({ bidiTestSkipPredicate }, run) => {
-    if (bidiTestSkipPredicate(test.info()))
-      test.skip(true);
+    test.fixme(bidiTestSkipPredicate(test.info()), 'marked as timeout in bidi expectations');
     await run();
   }, { auto: true, scope: 'test' }],
 });