Fix build process producing wheels with incorrect RECORD #2671
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
shutil.move("wheelhouse", self.dist_dir)
nestswheelhouse
directory itself inside ofdist/.tmp-XXX
instead of moving its contents there.That results in wheel with incorrect
RECORD
contents to end up indist
folder, which is then published.Solution
Move wheel with drivers and incorrect
RECORD
towheelhouse
and makeauditwheel
to put corrected wheel todist/.tmp-XXX
.Then remove
wheelhouse
folder.Build process snapshots
Below are snapshots of dist and wheelhouse folder contents for comparison.
Note: hashes were shrunk and some output removed for readability sake
Old setup.py
When python -mbuild --wheel finished:
New setup.py
When python -mbuild --wheel finished:
Instrumented code