Skip to content

tests: mark test as flaky #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 22, 2020
Merged

tests: mark test as flaky #248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
617ff2e
tests: mark test as flaky
mxschmitt Oct 22, 2020
c052e3b
mark test_page_bring_to_front_should_work as flaky
mxschmitt Oct 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions local-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ pytest-cov==2.10.1
pytest-sugar==0.9.4
pytest-xdist==2.1.0
pytest-timeout==1.4.2
flaky==3.7.0
pixelmatch==0.2.1
Pillow==7.2.0
mypy==0.782
Expand Down
2 changes: 2 additions & 0 deletions tests/async/test_defaultbrowsercontext.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
import os

import pytest
from flaky import flaky

from playwright.helper import Error

Expand Down Expand Up @@ -279,6 +280,7 @@ async def test_should_accept_user_data_dir(server, tmpdir, launch_persistent):
assert len(os.listdir(tmpdir)) > 0


@flaky
async def test_should_restore_state_from_userDataDir(
browser_type, launch_arguments, server, tmp_path_factory
):
Expand Down
2 changes: 2 additions & 0 deletions tests/async/test_headful.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
import asyncio

import pytest
from flaky import flaky


async def test_should_have_default_url_when_launching_browser(
Expand Down Expand Up @@ -179,6 +180,7 @@ async def test_should_not_override_viewport_size_when_passed_null(
await browser.close()


@flaky
async def test_page_bring_to_front_should_work(browser_type, launch_arguments):
browser = await browser_type.launch(**{**launch_arguments, "headless": False})
page1 = await browser.newPage()
Expand Down