Small pre-release fixes #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use trailing slash to keep dataset path-part.
The service logs all requests with collection information, the trace is duplicative.
Previously, outside of development environments, the PC signing SDK would use the production SAS URL in all environments. Instead, have the default stack point to its own deployed SAS service to fully test out integrated changes. Additionally, change the default dev environment SAS URL to staging, as it will most likely match any forthcoming releases to test against.
lossyrob
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small fixes found in pre-release testing:
describedbyType of change
How Has This Been Tested?
Local tests and dev stack deployments
Checklist:
Please delete options that are not relevant.