Skip to content

fix(scripts): resolve ShellCheck SC2034 and enable source-path resolution#443

Merged
WilliamBerryiii merged 1 commit into
mainfrom
fix/shellcheck-unused-instance-type
Apr 9, 2026
Merged

fix(scripts): resolve ShellCheck SC2034 and enable source-path resolution#443
WilliamBerryiii merged 1 commit into
mainfrom
fix/shellcheck-unused-instance-type

Conversation

@WilliamBerryiii
Copy link
Copy Markdown
Member

Pull Request

Description

Resolve ShellCheck SC2034 warning (instance_type assigned but not used) in evaluation/sil/scripts/submit-azureml-lerobot-eval.sh that has been blocking main CI for 8 consecutive runs, preventing release-please from updating PR #427 (release 0.7.0). Additionally, add source-path directives to .shellcheckrc to eliminate SC1091 informational notices across all repository scripts.

Type of Change

  • 🐛 Bug fix (non-breaking change fixing an issue)
  • ✨ New feature (non-breaking change adding functionality)
  • 💥 Breaking change (fix or feature causing existing functionality to change)
  • 📚 Documentation update
  • 🏗️ Infrastructure change (Terraform/IaC)
  • ♻️ Refactoring (no functional changes)

Component(s) Affected

  • infrastructure/terraform/prerequisites/ - Azure subscription setup
  • infrastructure/terraform/ - Terraform infrastructure
  • infrastructure/setup/ - OSMO control plane / Helm
  • workflows/ - Training and evaluation workflows
  • training/ - Training pipelines and scripts
  • docs/ - Documentation

Testing Performed

  • Terraform plan reviewed (no unexpected changes)
  • Terraform apply tested in dev environment
  • Training scripts tested locally with Isaac Sim
  • OSMO workflow submitted successfully
  • Smoke tests passed (smoke_test_azure.py)

Additional testing:

  • ShellCheck ran locally against the modified script — zero warnings/errors
  • Full lint suite (Invoke-ShellCheck.ps1) across all 42 repository scripts — PASS (0 errors, 0 warnings)
  • Verified source-path directives via --norc comparison: 2 SC1091 notices without directives → 0 with directives

Documentation Impact

  • No documentation changes needed
  • Documentation updated in this PR
  • Documentation issue filed

Bug Fix Checklist

  • Linked to issue being fixed
  • Regression test included, OR
  • Justification for no regression test: CI itself serves as the regression test — ShellCheck runs on every push to main and every PR via Invoke-ShellCheck.ps1 in strict mode

Checklist

…tion

- use instance_type variable in AzureML LeRobot eval submission script
- add source-path directives to .shellcheckrc for SC1091 resolution

🔧 - Generated by Copilot
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 9, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 9086576.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.41%. Comparing base (2366647) to head (9086576).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #443   +/-   ##
=======================================
  Coverage   64.41%   64.41%           
=======================================
  Files         251      251           
  Lines       15435    15435           
  Branches     2108     2060   -48     
=======================================
  Hits         9942     9942           
  Misses       5205     5205           
  Partials      288      288           
Flag Coverage Δ
pester 82.24% <ø> (ø)
pytest 92.40% <ø> (ø)
pytest-dataviewer 63.87% <ø> (ø)
pytest-fuzz 1.59% <ø> (ø)
vitest 50.80% <ø> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@WilliamBerryiii WilliamBerryiii merged commit 04438ea into main Apr 9, 2026
33 checks passed
@WilliamBerryiii WilliamBerryiii deleted the fix/shellcheck-unused-instance-type branch April 9, 2026 19:56
WilliamBerryiii pushed a commit that referenced this pull request Apr 9, 2026
🤖 I have created a release *beep* *boop*
---


##
[0.7.0](v0.6.1...v0.7.0)
(2026-04-09)


### ✨ Features

* **build:** add hve-core release pipeline with dependency SBOM and
signing artifacts
([#420](#420))
([2ff839a](2ff839a))
* **build:** enforce strict warnings across all linters
([#392](#392))
([b75e217](b75e217))
* **evaluation:** add fuzz testing infrastructure and property-based
tests
([#416](#416))
([d97d42c](d97d42c))
* **infrastructure:** add optional ADLS Gen2 data lake storage account
([#398](#398))
([3bb9012](3bb9012))
* **settings:** add HVE Core extension to workspace and devcontainer
recommendations
([#226](#226))
([f0735d8](f0735d8))


### 🐛 Bug Fixes

* **docs:** fix broken links, harden Docusaurus config, and integrate CI
workflow
([#430](#430))
([ea99997](ea99997))
* **scripts:** join shellcheck version output before -match to populate
$Matches
([#432](#432))
([8768e76](8768e76))
* **scripts:** map unmapped ShellCheck severity levels and harden
version parsing
([#434](#434))
([1e95a17](1e95a17))
* **scripts:** resolve ShellCheck SC2034 and enable source-path
resolution
([#443](#443))
([04438ea](04438ea))


### 🔧 Miscellaneous

* **deps-dev:** bump basic-ftp from 5.2.0 to 5.2.1
([#429](#429))
([438660a](438660a))
* **deps:** bump cryptography from 46.0.6 to 46.0.7
([#425](#425))
([2366647](2366647))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: physical-ai-toolchain-release[bot] <267194360+physical-ai-toolchain-release[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants