fix(scripts): resolve ShellCheck SC2034 and enable source-path resolution#443
Merged
Merged
Conversation
…tion - use instance_type variable in AzureML LeRobot eval submission script - add source-path directives to .shellcheckrc for SC1091 resolution 🔧 - Generated by Copilot
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #443 +/- ##
=======================================
Coverage 64.41% 64.41%
=======================================
Files 251 251
Lines 15435 15435
Branches 2108 2060 -48
=======================================
Hits 9942 9942
Misses 5205 5205
Partials 288 288
🚀 New features to boost your workflow:
|
nguyena2
approved these changes
Apr 9, 2026
WilliamBerryiii
pushed a commit
that referenced
this pull request
Apr 9, 2026
🤖 I have created a release *beep* *boop* --- ## [0.7.0](v0.6.1...v0.7.0) (2026-04-09) ### ✨ Features * **build:** add hve-core release pipeline with dependency SBOM and signing artifacts ([#420](#420)) ([2ff839a](2ff839a)) * **build:** enforce strict warnings across all linters ([#392](#392)) ([b75e217](b75e217)) * **evaluation:** add fuzz testing infrastructure and property-based tests ([#416](#416)) ([d97d42c](d97d42c)) * **infrastructure:** add optional ADLS Gen2 data lake storage account ([#398](#398)) ([3bb9012](3bb9012)) * **settings:** add HVE Core extension to workspace and devcontainer recommendations ([#226](#226)) ([f0735d8](f0735d8)) ### 🐛 Bug Fixes * **docs:** fix broken links, harden Docusaurus config, and integrate CI workflow ([#430](#430)) ([ea99997](ea99997)) * **scripts:** join shellcheck version output before -match to populate $Matches ([#432](#432)) ([8768e76](8768e76)) * **scripts:** map unmapped ShellCheck severity levels and harden version parsing ([#434](#434)) ([1e95a17](1e95a17)) * **scripts:** resolve ShellCheck SC2034 and enable source-path resolution ([#443](#443)) ([04438ea](04438ea)) ### 🔧 Miscellaneous * **deps-dev:** bump basic-ftp from 5.2.0 to 5.2.1 ([#429](#429)) ([438660a](438660a)) * **deps:** bump cryptography from 46.0.6 to 46.0.7 ([#425](#425)) ([2366647](2366647)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: physical-ai-toolchain-release[bot] <267194360+physical-ai-toolchain-release[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Resolve ShellCheck SC2034 warning (
instance_typeassigned but not used) inevaluation/sil/scripts/submit-azureml-lerobot-eval.shthat has been blocking main CI for 8 consecutive runs, preventing release-please from updating PR #427 (release 0.7.0). Additionally, addsource-pathdirectives to.shellcheckrcto eliminate SC1091 informational notices across all repository scripts.Type of Change
Component(s) Affected
infrastructure/terraform/prerequisites/- Azure subscription setupinfrastructure/terraform/- Terraform infrastructureinfrastructure/setup/- OSMO control plane / Helmworkflows/- Training and evaluation workflowstraining/- Training pipelines and scriptsdocs/- DocumentationTesting Performed
planreviewed (no unexpected changes)applytested in dev environmentsmoke_test_azure.py)Additional testing:
Invoke-ShellCheck.ps1) across all 42 repository scripts — PASS (0 errors, 0 warnings)source-pathdirectives via--norccomparison: 2 SC1091 notices without directives → 0 with directivesDocumentation Impact
Bug Fix Checklist
Invoke-ShellCheck.ps1in strict modeChecklist