ci(infrastructure): add terraform fmt and validate reusable workflow#294
ci(infrastructure): add terraform fmt and validate reusable workflow#294nacholiya wants to merge 2 commits into
Conversation
|
@microsoft-github-policy-service agree |
|
Hi, this PR adds a reusable Terraform fmt and validate CI workflow. Could you please approve the workflow run so CI checks can proceed? |
|
Hi @nacholiya, thanks for the contribution and for engaging with this issue! This PR is a duplicate of #293, which was submitted a few minutes earlier and covers the same scope — I'll be closing this PR as already addressed by #293. A note for future contributions: Before starting work on an open issue, please check whether the issue is already assigned to someone. If it is, the work is likely in progress. You're always welcome to comment on the issue to express interest or discuss collaboration — maintainers can reassign or coordinate from there. We'll be updating the contribution workflow guide to make this explicit to avoid similar situations. Your PR allowed us to identify a gap in our contributor docs. Thank you again for your interest in the project, we encourage you to pick up other open, unassigned issues! |
…#299) Clarify issue assignment requirement before starting work. Two contributors independently opened PRs for the same issue (#288 → #293 and #294) because the contribution workflow didn't require issue assignment before starting work. Add step 1 to PR Workflow in `docs/contributing/contribution-workflow.md`: "Check the issue is open and unassigned" — request assignment via comment before starting work. Covers both "already assigned" and `needs-triage` edge cases. Renumbers existing steps 2–9 and updates `ms.date`. The new step reads: ```markdown 1. **Check the issue is open and unassigned.** Comment on the issue to request assignment before starting any work. Maintainers will assign you when confirmed. * If the issue is already assigned to someone, do not open a competing PR without first coordinating with the assignee or a maintainer. * Issues labelled `needs-triage` are not ready to be picked up. You are welcome to comment your interest in being assigned — maintainers will follow up once triage is complete. ``` ## Type of Change - [x] 📚 Documentation update ## Component(s) Affected - [x] `docs/` - Documentation ## Testing Performed - [x] `npm run lint:md` passes with 0 errors - [x] `cspell` spell check passes with 0 issues ## Documentation Impact - [x] Documentation updated in this PR ## Checklist - [x] My code follows the [project conventions](copilot-instructions.md) - [x] Commit messages follow [conventional commit format](instructions/commit-message.instructions.md) - [x] I have performed a self-review - [x] Documentation impact assessed above - [x] No new linting warnings introduced Closes #295 --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: katriendg <838216+katriendg@users.noreply.github.com>
2 participants
Pull Request
Description
Add a reusable GitHub Actions workflow for Terraform validation.
terraform fmt -check -recursiveterraform init -backend=falseandterraform validatesoft-failinputCloses #288
Type of Change
Component(s) Affected
infrastructure/terraform/prerequisites/- Azure subscription setupinfrastructure/terraform/- Terraform infrastructureinfrastructure/setup/- OSMO control plane / Helmworkflows/- Training and evaluation workflowstraining/- Training pipelines and scriptsdocs/- DocumentationTesting Performed
planreviewed (no unexpected changes)applytested in dev environmentsmoke_test_azure.py)Documentation Impact
Bug Fix Checklist
Complete this section for bug fix PRs. Skip for other contribution types.
Checklist