Repository navigation
ClrMD version bump - #2478
Merged
Merged
ClrMD version bump#2478
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 7c3d07ec-6b2e-43c4-a583-50a131b4f7ad
Honor unchecked flat DAC queries, including cross-platform candidates, and continue local lookup past mismatched or unreadable images. Add regression coverage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 7c3d07ec-6b2e-43c4-a583-50a131b4f7ad
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
| Console.WriteLine("Usage: HeapDump [/MaxDumpCountK=n /Freeze] ProcessIdOrName OutputHeapDumpFile"); | ||
| Console.WriteLine("Usage: HeapDump [/MaxDumpCountK=n] /processDump DumpFile OutputHeapDumpFile"); | ||
| Console.WriteLine("Usage: HeapDump [/MaxDumpCountK=n /Freeze /VerifyDacOnWindows:true|false] ProcessIdOrName OutputHeapDumpFile"); | ||
| Console.WriteLine("Usage: HeapDump [/MaxDumpCountK=n /VerifyDacOnWindows:true|false] /processDump DumpFile OutputHeapDumpFile"); |
There was a problem hiding this comment.
There's an extra space between /processDump and DumpFile
| /// <summary> | ||
| /// Whether to verify DAC signatures on Windows when capturing or converting a heap snapshot. | ||
| /// </summary> | ||
| public bool VerifyDacOnWindows = true; |
There was a problem hiding this comment.
Nit: Inconsistent way to express the purpose of the field compared with other fields immediately before and after this one.
Matt Connew (mconnew)
approved these changes
Oct 14, 2026
Matt Connew (mconnew)
left a comment
Matt Connew (mconnew)
left a comment
Member
There was a problem hiding this comment.
Just a couple of minor nits, no functional issues
This was referenced Oct 14, 2026
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates ClrMD from
4.0.0-beta.24314.3to4.2.750101.DataTargetOptions, preserving configured symbol paths and local caches.Validated with a Debug solution build, 23 focused tests, and Windows/Linux dump conversions (large-dump walks capped at 100,000 objects).