Repository navigation
Preserve source and callback when cloning predefined dynamic events - #2472
Merged
Brian Robbins (brianrob) merged 1 commit intoOct 2, 2026
Conversation
Keep populated predefined dynamic event copies attached to their source and callback while leaving template clones detached. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
evschaff
changed the title
Brian Robbins (brianrob)
approved these changes
Oct 2, 2026
Brian Robbins (brianrob)
left a comment
Brian Robbins (brianrob)
left a comment
Member
There was a problem hiding this comment.
LGTM. Thanks evschaff!
This was referenced Oct 14, 2026
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix cloning of populated
PredefinedDynamicEventinstances.TraceLog.GetEvent()returns a clone, but the current override unconditionally clears its source and callback as if every clone were an unpopulated parser template. For Universal CPU events, subsequently callingCallStack()fails with:This is an existing issue, also present in TraceEvent 3.2.6.
Changes
traceEventSourceandTargetonly when cloning an unpopulated template (eventRecord == null).TraceEvent.Clone()behavior.CloneToTemplate()continues to explicitly detach its result.Validation
On this branch, Windows x64:
UniversalTests: 10 passed.TraceEvent.Tests.csproj: succeeded.The full repository test suite and other target frameworks were not run for this branch.