Fix GC dynamic ETLX replay#2440
Merged
brianrob merged 3 commits intoJul 15, 2026
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 38430826-404a-4dd2-a410-a64c3fc1c158
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 38430826-404a-4dd2-a410-a64c3fc1c158
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 38430826-404a-4dd2-a410-a64c3fc1c158
leculver
approved these changes
Jul 15, 2026
Member
Author
|
@microsoft-github-policy-service rerun |
This was referenced Jul 18, 2026
Open
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PerfView 3.2.4 can throw
ArgumentOutOfRangeExceptionwhen GC Stats or Heap Analyzer replaysGC/CommittedUsageevents from ETLX. During conversion,FixupData()classifies the raw dynamic event and the ETLX persists the synthetic event ID, but the original dynamic payload envelope remains unchanged. On replay, the typed template therefore still needs to parse that envelope.This change refreshes the payload layout in
EventPayloadonly when processing aTraceLog. Raw ETW and EventPipe dispatch continue using the payload prepared byFixupData(), avoiding redundant parsing. Fixed-offsetCommittedUsagefields also return safe defaults for truncated payloads.Regression coverage includes valid ETLX replay without
FixupData(), reused replay templates with distinct payloads, and malformed payload access through properties,PayloadValues, andToXml.Fixes #2438