Migrate ir_builder to use onnx_ir #2457

justinchuby · 2025-07-15T19:44:08Z

Signed-off-by: Justin Chu [email protected]

Signed-off-by: Justin Chu <[email protected]>

codecov · 2025-07-15T19:47:53Z

Codecov Report

❌ Patch coverage is 8.65052% with 264 lines in your changes missing coverage. Please review.
✅ Project coverage is 10.84%. Comparing base (8a94ad6) to head (7f2fd2b).

Files with missing lines	Patch %	Lines
onnxscript/_converter.py	5.01%	246 Missing ⚠️
onnxscript/_internal/_analysis.py	38.46%	8 Missing ⚠️
onnxscript/_converter_test.py	0.00%	3 Missing ⚠️
onnxscript/_internal/_analysis_test.py	25.00%	3 Missing ⚠️
onnxscript/_internal/autocast.py	0.00%	1 Missing ⚠️
onnxscript/ir/_schemas.py	66.66%	1 Missing ⚠️
onnxscript/main.py	50.00%	1 Missing ⚠️
onnxscript/values.py	50.00%	1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (8a94ad6) and HEAD (7f2fd2b). Click for more details.

HEAD has 83 uploads less than BASE

Flag BASE (8a94ad6) HEAD (7f2fd2b)

84 1

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2457       +/-   ##
===========================================
- Coverage   70.46%   10.84%   -59.62%     
===========================================
  Files         224      214       -10     
  Lines       26572    25011     -1561     
  Branches     2637     2530      -107     
===========================================
- Hits        18723     2712    -16011     
- Misses       6928    22288    +15360     
+ Partials      921       11      -910

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Justin Chu <[email protected]>

onnxscript/_converter.py

Signed-off-by: Justin Chu <[email protected]>

onnxscript/_converter.py

+                op_signature, args, kwargs
            )
-            args = [self._translate_opt_expr(x) for x in args]
+            onnx_inputs = [self._translate_opt_expr(x) for x in inputs]


onnxscript/_converter.py

+                op_signature, args, kwargs
            )
-            args = [self._translate_opt_expr(x) for x in args]
+            onnx_inputs = [self._translate_opt_expr(x) for x in inputs]


onnxscript/_converter.py

+            elif kwargs.get(param.name) is not None:
+                attribute = kwargs[param.name]  # type: ignore[assignment]
+            else:
+                if param.required:


onnxscript/ir/_schemas.py

 from __future__ import annotations

 import collections.abc
+import copy


onnxscript/ir/_schemas.py

 from __future__ import annotations

 import collections.abc
+import copy


Signed-off-by: Justin Chu <[email protected]>

onnxscript/_converter_test.py

        top_level_ast = ast.parse(source)
        f_ast = top_level_ast.body[0]
-        cvt = converter.Converter(
+        cvt = _converter.Converter(


onnxscript/main.py

    # TODO: cleanup Converter interface/API, separating checker from
    # converter
-    convert = converter.Converter(
+    convert = _converter.Converter(


onnxscript/values.py

        global_names = module.__dict__.copy()
        global_names.update(closure.nonlocals)
-        converter = converter_module.Converter(
+        converter = _converter.Converter(


Signed-off-by: Justin Chu <[email protected]>

onnxscript/_converter.py

onnxscript/_internal/_analysis_test.py

    def analyze(self, fun):
        source, parse_tree = ast_utils.get_src_and_ast(fun)
-        analysis.do_liveness_analysis(parse_tree, formatter(source))
+        _analysis.do_liveness_analysis(parse_tree, formatter(source))


Signed-off-by: Justin Chu <[email protected]>

onnxscript/_converter.py

Signed-off-by: Justin Chu <[email protected]>

onnxscript/_converter.py

onnxscript/_internal/autocast.py

+    converter_: _converter.Converter,
    op_schema: Optional[OpSchema],
-    args: Sequence[Optional[converter.Variable]],
+    args: Sequence[Optional[_converter.Variable]],


onnxscript/_internal/autocast.py

    """

-    def get_type_info(x: Optional[converter.Variable]) -> Optional[converter.Variable]:
+    def get_type_info(x: Optional[_converter.Variable]) -> Optional[_converter.Variable]:


onnxscript/_internal/autocast.py


    def cast_like(
-        x: Optional[converter.Variable], y: Optional[converter.Variable]
+        x: Optional[_converter.Variable], y: Optional[_converter.Variable]


Signed-off-by: Justin Chu <[email protected]>

onnxscript/_converter.py

-            tensor = autocast.pyvalue_to_onnx_tensor(ovar, pyvalue)
-        except ValueError as e:
+            tensor = ir.tensor(pyvalue, name=var_name)
+        except Exception as e:


onnxscript/_converter.py

            preferred_name = f"return_val{suffix}"
            return_var = self._translate_expr(exp, preferred_name).name
            val = self._lookup(return_var, self._source_of(exp), False)
+            assert type(val) is values.Dynamic


Signed-off-by: Justin Chu <[email protected]>

onnxscript/_converter.py

+    return tuple(reversed(inputs_reversed)), named_attrs
+
+
+def _to_onnx_ref_attr(val: values.AttrRef, info: sourceinfo.SourceInfo | None) -> ir.Attr:


onnxscript/values.py


-from onnxscript import converter as converter_module
-from onnxscript import irbuilder, sourceinfo, type_annotation
+from onnxscript import _converter, irbuilder, sourceinfo, type_annotation


onnxscript/values.py


-from onnxscript import converter as converter_module
-from onnxscript import irbuilder, sourceinfo, type_annotation
+from onnxscript import _converter, irbuilder, sourceinfo, type_annotation


Signed-off-by: Justin Chu <[email protected]>

onnxscript/_converter.py

Signed-off-by: Justin Chu <[email protected]>

onnxscript/_converter.py

    Sequence,
    Tuple,
    Union,
+    _GenericAlias


onnxscript/_converter.py

-        """
-        self.name = name
-        self.is_castable = castable
+class DynamicKind(IntFlag):


onnxscript/_converter.py

-        """
-        self.name = name
-        self.is_castable = castable
+class DynamicKind(IntFlag):


onnxscript/_converter.py

-        """
-        self.name = name
-        self.is_castable = castable
+class DynamicKind(IntFlag):


onnxscript/_converter.py

+        self._converter = converter
+
+    def get_or_create_value(
+        self, var: str, info: sourceinfo.SourceInfo


onnxscript/_converter.py

Signed-off-by: Justin Chu <[email protected]>

onnxscript/_converter.py

+def is_base_type_bool(attr: ir.Attr) -> bool:
+    """Check if the attribute is a boolean type."""
+    # FIXME: Add meta to attributes
+    attr.meta[_SOURCEINFO_FIELD]


justinchuby · 2025-10-29T23:43:04Z

Replaced by #2665

justinchuby added 4 commits July 15, 2025 12:11

Rename converter

69b08fb

Signed-off-by: Justin Chu <[email protected]>

Update fields

7e0a767

Signed-off-by: Justin Chu <[email protected]>

wip

8c7abc6

Signed-off-by: Justin Chu <[email protected]>

make locals a stack

370a9f5

Signed-off-by: Justin Chu <[email protected]>

github-project-automation bot added this to ONNX Script Review Board Jul 15, 2025

github-project-automation bot moved this to Todo in ONNX Script Review Board Jul 15, 2025

wip

10473a9

Signed-off-by: Justin Chu <[email protected]>

wip

3889e70

Signed-off-by: Justin Chu <[email protected]>

github-advanced-security bot found potential problems Jul 16, 2025

View reviewed changes

onnxscript/_converter.py Fixed Show fixed Hide fixed

justinchuby added 2 commits July 15, 2025 17:50

update

e09fdcc

Signed-off-by: Justin Chu <[email protected]>

wip

fa60de6

Signed-off-by: Justin Chu <[email protected]>

github-advanced-security bot found potential problems Jul 16, 2025

View reviewed changes

justinchuby added 3 commits July 16, 2025 15:27

wip

3aff171

Signed-off-by: Justin Chu <[email protected]>

wip

761451a

Signed-off-by: Justin Chu <[email protected]>

wip

882af66

Signed-off-by: Justin Chu <[email protected]>

github-advanced-security bot found potential problems Jul 18, 2025

View reviewed changes

justinchuby added 4 commits July 18, 2025 16:29

update

852cc42

Signed-off-by: Justin Chu <[email protected]>

continue

be610e9

Signed-off-by: Justin Chu <[email protected]>

Update analysis pass

98754ab

Signed-off-by: Justin Chu <[email protected]>

live_out

22eeddc

Signed-off-by: Justin Chu <[email protected]>

github-advanced-security bot found potential problems Jul 19, 2025

View reviewed changes

justinchuby added 5 commits July 18, 2025 17:49

Update if

c74b854

Signed-off-by: Justin Chu <[email protected]>

fmt

2c43e9a

Signed-off-by: Justin Chu <[email protected]>

Update emit ordering

c53b8f3

Signed-off-by: Justin Chu <[email protected]>

update emit call

c84ad91

Signed-off-by: Justin Chu <[email protected]>

attrs

0af0707

Signed-off-by: Justin Chu <[email protected]>

github-advanced-security bot found potential problems Jul 22, 2025

View reviewed changes

onnxscript/_converter.py Fixed Show fixed Hide fixed

return values

2196f99

Signed-off-by: Justin Chu <[email protected]>

github-advanced-security bot found potential problems Jul 22, 2025

View reviewed changes

justinchuby added 4 commits July 24, 2025 10:50

wip

b56a161

Signed-off-by: Justin Chu <[email protected]>

Merge branch 'main' into justinchu/migrate-irbuilder

359eb0b

wip

b04a455

Signed-off-by: Justin Chu <[email protected]>

wip

e4c9576

Signed-off-by: Justin Chu <[email protected]>

github-advanced-security bot found potential problems Jul 25, 2025

View reviewed changes

refactor

11a735e

Signed-off-by: Justin Chu <[email protected]>

github-advanced-security bot found potential problems Jul 29, 2025

View reviewed changes

justinchuby added 2 commits July 29, 2025 17:30

_ValueEnvironment

0cd1f20

Signed-off-by: Justin Chu <[email protected]>

emit_const

d98e8b5

Signed-off-by: Justin Chu <[email protected]>

github-advanced-security bot found potential problems Jul 30, 2025

View reviewed changes

onnxscript/_converter.py Fixed Show fixed Hide fixed

onnxscript/_converter.py Fixed Show fixed Hide fixed

justinchuby added 2 commits August 1, 2025 08:39

Merge branch 'main' into justinchu/migrate-irbuilder

38b1c03

_ValueEnvironment

f1c10c6

Signed-off-by: Justin Chu <[email protected]>

github-advanced-security bot found potential problems Aug 16, 2025

View reviewed changes

fixme

ce2428f

Signed-off-by: Justin Chu <[email protected]>

github-advanced-security bot found potential problems Aug 16, 2025

View reviewed changes

justinchuby self-assigned this Oct 27, 2025

Merge branch 'main' into justinchu/migrate-irbuilder

7f2fd2b

justinchuby mentioned this pull request Oct 29, 2025

Migrate ir_builder to use onnx_ir (take 2) #2665

Draft

		return tuple(reversed(inputs_reversed)), named_attrs


		def _to_onnx_ref_attr(val: values.AttrRef, info: sourceinfo.SourceInfo \| None) -> ir.Attr:

Migrate ir_builder to use onnx_ir #2457

Are you sure you want to change the base?

Migrate ir_builder to use onnx_ir #2457

Uh oh!

Conversation

justinchuby commented Jul 15, 2025

Uh oh!

codecov bot commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Check warning

Check warning

Check notice

Check warning

Check warning

Check failure

Check failure

Check failure

Uh oh!

Uh oh!

Check failure

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Check failure

Check failure

Check failure

Check warning

Check notice

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Check failure

Check warning

Check warning

Uh oh!

Uh oh!

Check warning

Check failure

Check failure

Check failure

Check warning

Uh oh!

Uh oh!

Uh oh!

Check warning

justinchuby commented Oct 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Jul 15, 2025 •

edited

Loading