Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misleading annotation in the documentation #2046

Merged
merged 7 commits into from
Feb 20, 2025
Merged

Conversation

xadupre
Copy link
Member

@xadupre xadupre commented Jan 28, 2025

The function does not seem to work inplace in all cases.

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.20%. Comparing base (288481d) to head (509e37d).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
onnxscript/tools/benchmark/benchmark_helpers.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2046      +/-   ##
==========================================
+ Coverage   71.76%   72.20%   +0.44%     
==========================================
  Files         225      216       -9     
  Lines       29275    28733     -542     
  Branches     3455     3412      -43     
==========================================
- Hits        21010    20748     -262     
+ Misses       7133     6862     -271     
+ Partials     1132     1123       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinchuby
Copy link
Collaborator

I updated the function signature to hide the proto related types. Users are discouraged to send in proto types but the logic is still there for now.

@justinchuby justinchuby enabled auto-merge (squash) February 20, 2025 00:13
@justinchuby justinchuby added the topic: documentation Improvements or additions to documentation label Feb 20, 2025
@justinchuby justinchuby merged commit 0361971 into microsoft:main Feb 20, 2025
22 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: documentation Improvements or additions to documentation
Projects
Development

Successfully merging this pull request may close these issues.

4 participants