Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rewriter] Remove redundant op.Slice and op.ScatterND #1925

Merged
merged 7 commits into from
Nov 1, 2024

address reviews

7eca5a6
Select commit
Loading
Failed to load commit list.
Merged

[rewriter] Remove redundant op.Slice and op.ScatterND #1925

address reviews
7eca5a6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Nov 1, 2024 in 1s

74.10% of diff hit (target 75.23%)

View this Pull Request on Codecov

74.10% of diff hit (target 75.23%)

Annotations

Check warning on line 34 in onnxscript/rewriter/collapse_slices.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

onnxscript/rewriter/collapse_slices.py#L33-L34 

Added lines #L33 - L34 were not covered by tests

Check warning on line 37 in onnxscript/rewriter/collapse_slices.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

onnxscript/rewriter/collapse_slices.py#L36-L37 

Added lines #L36 - L37 were not covered by tests

Check warning on line 40 in onnxscript/rewriter/collapse_slices.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

onnxscript/rewriter/collapse_slices.py#L39-L40 

Added lines #L39 - L40 were not covered by tests

Check warning on line 43 in onnxscript/rewriter/collapse_slices.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

onnxscript/rewriter/collapse_slices.py#L42-L43 

Added lines #L42 - L43 were not covered by tests

Check warning on line 47 in onnxscript/rewriter/collapse_slices.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

onnxscript/rewriter/collapse_slices.py#L46-L47 

Added lines #L46 - L47 were not covered by tests

Check warning on line 50 in onnxscript/rewriter/collapse_slices.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

onnxscript/rewriter/collapse_slices.py#L49-L50 

Added lines #L49 - L50 were not covered by tests

Check warning on line 60 in onnxscript/rewriter/collapse_slices.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

onnxscript/rewriter/collapse_slices.py#L59-L60 

Added lines #L59 - L60 were not covered by tests

Check warning on line 107 in onnxscript/rewriter/collapse_slices.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

onnxscript/rewriter/collapse_slices.py#L106-L107 

Added lines #L106 - L107 were not covered by tests

Check warning on line 110 in onnxscript/rewriter/collapse_slices.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

onnxscript/rewriter/collapse_slices.py#L109-L110 

Added lines #L109 - L110 were not covered by tests

Check warning on line 118 in onnxscript/rewriter/collapse_slices.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

onnxscript/rewriter/collapse_slices.py#L117-L118 

Added lines #L117 - L118 were not covered by tests

Check warning on line 121 in onnxscript/rewriter/collapse_slices.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

onnxscript/rewriter/collapse_slices.py#L120-L121 

Added lines #L120 - L121 were not covered by tests

Check warning on line 31 in onnxscript/rewriter/testing.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

onnxscript/rewriter/testing.py#L31 

Added line #L31 was not covered by tests
View more details on Codecov