Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more URLs to package #1156

Merged
merged 7 commits into from
Nov 22, 2023
Merged

Add more URLs to package #1156

merged 7 commits into from
Nov 22, 2023

Conversation

take-cheeze
Copy link
Contributor

Sorry to add "complex logic in setup.py".
Though it's a development feature

closes #1155

I'm specifying url since it's not allowed in pyproject.toml: pypa/packaging-problems#606

@justinchuby
Copy link
Collaborator

justinchuby commented Nov 15, 2023

Thanks. Would it be possible to instead overwrite the Commit field in the toml file using a script in CI?

The current looks good

@justinchuby justinchuby added run release CIs Release CI will run for PRs with this label topic: release labels Nov 15, 2023
@justinchuby justinchuby self-requested a review November 15, 2023 18:10
setup.py Fixed Show fixed Hide fixed
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (00ea75e) 78.62% compared to head (1e8fef5) 78.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1156      +/-   ##
==========================================
+ Coverage   78.62%   78.63%   +0.01%     
==========================================
  Files         118      118              
  Lines       15312    15312              
  Branches     1660     1660              
==========================================
+ Hits        12039    12041       +2     
+ Misses       2887     2884       -3     
- Partials      386      387       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinchuby
Copy link
Collaborator

Could you sign the CLA? Thanks

@take-cheeze
Copy link
Contributor Author

@microsoft-github-policy-service agree

@justinchuby justinchuby merged commit 77ef131 into microsoft:main Nov 22, 2023
26 of 30 checks passed
@take-cheeze take-cheeze deleted the more_urls branch November 24, 2023 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run release CIs Release CI will run for PRs with this label topic: release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is it possible to tag released commits?
2 participants