Enable TRT EP for C# #7482
Enable TRT EP for C# #7482
Conversation
|
wonder why CI isn't automatically kicked off. are you missing some membership |
|
/azp run orttraining-linux-ci-pipeline,orttraining-mac-ci-pipeline,orttraining-linux-gpu-ci-pipeline,centos7_cpu,Linux CPU Minimal Build E2E CI Pipeline,Linux Nuphar CI Pipeline,MacOS NoContribops CI Pipeline,Linux OpenVINO CI Pipeline,orttraining-distributed, orttraining-amd-gpu-ci-pipeline |
|
/azp run Linux CPU CI Pipeline,Linux CPU x64 NoContribops CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,MacOS CI Pipeline,MacOS NoContribops CI Pipeline,Windows CPU CI Pipeline,Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline |
|
Azure Pipelines successfully started running 8 pipeline(s). |
|
/azp run orttraining-ortmodule, orttraining-ortmodule-distributed |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Azure Pipelines successfully started running 9 pipeline(s). |
| SessionOptions options = new SessionOptions(); | ||
| NativeApiStatus.VerifySuccess(NativeMethods.OrtSessionOptionsAppendExecutionProvider_Tensorrt(options.Handle, deviceId)); | ||
| NativeApiStatus.VerifySuccess(NativeMethods.OrtSessionOptionsAppendExecutionProvider_CUDA(options.Handle, deviceId)); | ||
| NativeApiStatus.VerifySuccess(NativeMethods.OrtSessionOptionsAppendExecutionProvider_CPU(options.Handle, 1)); |
There was a problem hiding this comment.
We are not guarding against the options leak on exception here.
There was a problem hiding this comment.
looks like all the other MakeSessionOption static methods in this file are following the same pattern.
what's your suggestion. how should we recover here. this method returns options.
prevent the leak but propagate the exception?
There was a problem hiding this comment.
We just try/catch. In catch we do options.Dispose() and then rethrow.
There was a problem hiding this comment.
Need to fix the other locations (2?)
There was a problem hiding this comment.
@yuslepukhin are you suggesting using try/catch as previous discussion? #7315 (comment)
There was a problem hiding this comment.
I've added try/catch around native methods.
There was a problem hiding this comment.
If you think others should also properly address this options leak, I can help modify in another PR.
Description:
Enable TRT EP for C#.
This PR is derived from #7179 but without supporting provider options configuration.