Skip to content

Update packaging pipelines #6664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
snnn merged 1 commit into from
Feb 17, 2021
Merged

Update packaging pipelines #6664

snnn merged 1 commit into from
Feb 17, 2021

Conversation

@snnn
Copy link
Contributor

@snnn snnn commented Feb 12, 2021

Description:

  1. Change how PACKAGENAME is handled in nuget pipelines. Use uppercases in all the places, it is much simpler!! If without this change, the macos test step would fail if the package name isn't the default value. It happens in the noopenmp pipeline.
  2. Move machine pools: change the machine pool Linux-GPU-CUDA10 to Onnxruntime-Linux-GPU. This change is only for the packaging pipelines.
  3. Fix a problem in the java packaging pipeline. I didn't set java artifact_id correctly. Before this change, CPU and GPU package were all set to "onnxruntime". But indeed the gpu one should be "onnxruntime_gpu".

Motivation and Context

  • Why is this change required? What problem does it solve?
  • If it fixes an open issue, please link to the issue here.

@snnn snnn requested a review from a team as a code owner February 12, 2021 08:33
@snnn snnn mentioned this pull request Feb 12, 2021
Merged
@snnn snnn force-pushed the snnn/replace_pool branch from 2935fea to 3046eb7 Compare February 16, 2021 22:56
@snnn snnn force-pushed the snnn/replace_pool branch from a3df54b to 30baa54 Compare February 17, 2021 09:02
@snnn snnn force-pushed the snnn/replace_pool branch from 30baa54 to 74b9ace Compare February 17, 2021 09:09
@snnn snnn merged commit 0be5475 into master Feb 17, 2021
@snnn snnn deleted the snnn/replace_pool branch February 17, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@RandySheriffH RandySheriffH RandySheriffH approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@snnn @RandySheriffH @oliviajain