Require explicit inclusion of custom op support in a minimal build #6663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntribute too much binary growth to an Android build. Add ability to explicitly enable custom op support in a minimal build. Change one minimal build CI to test adding custom op support (unit tests are run in that build to validate)
…xplicitInclusionOfCustomOpSupportInMinimalBuild
edgchen1
reviewed
Feb 12, 2021
edgchen1
reviewed
Feb 12, 2021
guoyu-wang
approved these changes
Feb 13, 2021
skottmckay
deleted the
skottmckay/RequireExplicitInclusionOfCustomOpSupportInMinimalBuild
branch
edgchen1
reviewed
Feb 13, 2021
| # Disable python tests in a reduced build as we don't know which ops have been included and which | ||
| # models can run | ||
| if args.include_ops_by_config or args.minimal_build != 'off': | ||
| if args.include_ops_by_config or args.minimal_build: |
Contributor
There was a problem hiding this comment.
one more place to update to args.minimal_build is not None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Remove support from custom ops from the base minimal build as they contribute too much binary growth to an Android build.
Add ability to explicitly enable custom op support in a minimal build.
Change one minimal build CI to test adding custom op support (unit tests are run in that build to validate)
Motivation and Context
Reduce base minimal build size on Android.