Consolidate MLTypeCallDispatcher classes #6651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuslepukhin
reviewed
Feb 12, 2021
| * | ||
| * The constructor accepts a value corresponding to a tensor element type. | ||
| * For example, it can be obtained from: | ||
| * input_tensor->DataType()->AsPrimitiveType()->GetDataType() |
Member
There was a problem hiding this comment.
->DataType()->AsPrimitiveType()->GetDataType() [](start = 17, length = 46)
->GetElementType() #Resolved
yuslepukhin
reviewed
Feb 12, 2021
| * @param dt_type The value corresponding to the tensor element type to be | ||
| * dispatched to. This can be obtained from | ||
| * utils::ToTensorProtoElementType<T>() or | ||
| * input_tensor->DataType()->AsPrimitiveType()->GetDataType(). |
Member
There was a problem hiding this comment.
DataType()->AsPrimitiveType()->GetDataType(). [](start = 26, length = 45)
->GetElementType() #Resolved
yuslepukhin
reviewed
Feb 12, 2021
| static_cast<void>(std::array<int, sizeof...(Types)>{ | ||
| helper.template Invoke<Types>(Fn<Types>(), std::forward<Args>(args)...)...}); | ||
| helper.template Invoke<Types>( | ||
| boost::mp11::mp_apply<Fn, boost::mp11::mp_push_back<LeadingTemplateArgTypeList, Types>>(), |
Member
There was a problem hiding this comment.
boost::mp11::mp_push_back<LeadingTemplateArgTypeList, Types> [](start = 37, length = 61)
Why not simply SupportedTypesList? #Resolved
Member
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Consolidate different MLTypeCallDispatcher classes into a single one.
Motivation and Context
Clean up.