Add CI build with type reduction enabled #6622
Conversation
…nable type reduction.
| onnxruntimecentoscpubuild \ | ||
| /bin/bash /onnxruntime_src/tools/ci_build/github/linux/ort_minimal/build_minimal_ort_and_run_tests.sh | ||
| /bin/bash /onnxruntime_src/tools/ci_build/github/linux/ort_minimal/build_minimal_ort_and_run_tests.sh \ | ||
| --build-directory /build \ |
There was a problem hiding this comment.
Nit, can use --build-directory /build/without_type_reduction
Or clear the build at the end of build_minimal_ort_and_run_tests.sh
#Resolved
There was a problem hiding this comment.
i can use a more specific build directory, good idea. i think we need to keep this build directory around for the later upload test results step though #Resolved
|
|
||
| - task: CmdLine@2 | ||
| displayName: Build minimal onnxruntime with exceptions enabled and type reduction enabled and run tests | ||
| inputs: |
There was a problem hiding this comment.
nit: Might be easier to grok the steps if 'DISABLED' and 'ENABLED' in the displayName values was all caps. #Resolved
| onnxruntimecentoscpubuild \ | ||
| /bin/bash /onnxruntime_src/tools/ci_build/github/linux/ort_minimal/build_minimal_ort_and_run_tests.sh \ | ||
| --build-directory /build/with_type_reduction \ | ||
| --reduced-ops-config /home/onnxruntimedev/.test_data/required_ops_and_types.ort_models.config \ |
There was a problem hiding this comment.
Do we need to throw away the build between having type reduction disabled and enabled, or can we just do an incremental build to save time? Not sure if running via docker supports that though.
There was a problem hiding this comment.
it should be possible to do an incremental build. however, the test report files will have the same name, so need to upload them twice or somehow not overwrite them. one of these reduced minimal build steps takes about 4 minutes, so the time savings would not be huge.
IMO, i'd prefer doing a clean build for simplicity. unless we specifically want to test switching the type reduction on with an existing build directory/repo.
In reply to: 573278739 [](ancestors = 573278739)
| # Perform a minimal build with required ops and run ORT minimal build UTs | ||
| python3 /onnxruntime_src/tools/ci_build/build.py \ | ||
| --build_dir /build --cmake_generator Ninja \ | ||
| --build_dir ${BUILD_DIR} --cmake_generator Ninja \ |
There was a problem hiding this comment.
Can we add something to echo the size of libonnxruntime.so post-build so that it's captured in the CI output? Will help if we ever need to manually check that a reduced ops + types build is smaller than just a reduced ops build. #Resolved
|
/azp run Windows CPU CI Pipeline |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Windows CPU CI Pipeline |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run orttraining-win-ci-pipeline |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Description
Add a CI build with type reduction enabled.
Motivation and Context
Test type reduction from a CI build.