Skip to content

Conversation

@faxu
Copy link
Contributor

@faxu faxu commented Feb 9, 2021

No description provided.

@faxu faxu requested a review from a team as a code owner February 9, 2021 18:19
@faxu faxu changed the title Fix broken links in readme [WIP] Fix broken links in readme Feb 9, 2021
README.md Outdated
* [Supported operators/types](./docs/OperatorKernels.md)
* *Operators not supported in the current ONNX spec may be available as a [Contrib Operator](./docs/ContribOperators.md)*
* [Extensibility: Add a custom operator/kernel](docs/AddingCustomOp.md)
* [Extensibility: Add a custom operator/kernel](https://www.onnxruntime.ai/docs/how-to/add-custom-op.html)
Copy link
Member

@xadupre xadupre Feb 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have written (./docs/how-to/AddingCustomOp.md) since the link above is working. Relative link are better if the website is published at a different location.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's in a different branch. So it can't be a relative link.

README.md Outdated
* GPU Provider - NVIDIA CUDA
* GPU Provider - DirectML (Windows)
* *On Windows, the [DirectML execution provider](./docs/execution_providers/DirectML-ExecutionProvider.md) is recommended for optimal performance and compatibility with a broad set of GPUs.*
* *On Windows, the [DirectML execution provider](https://www.onnxruntime.ai/docs/reference/execution-providers/DirectML-ExecutionProvider.html) is recommended for optimal performance and compatibility with a broad set of GPUs.*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above.

@faxu faxu changed the title [WIP] Fix broken links in readme Update readme to reference docs webpage content Feb 9, 2021
@snnn
Copy link
Contributor

snnn commented Feb 10, 2021

/azp run Windows CPU CI Pipeline

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@faxu
Copy link
Contributor Author

faxu commented Feb 11, 2021

/azp run Windows CPU CI Pipeline

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@faxu faxu closed this Feb 12, 2021
@faxu faxu reopened this Feb 12, 2021
@faxu faxu merged commit fba46a7 into master Feb 12, 2021
@faxu faxu deleted the faxu-readme branch February 12, 2021 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants