Skip to content

Conversation

@snnn
Copy link
Contributor

@snnn snnn commented Feb 6, 2021

Description:

  1. Fix Nuget package build break caused by Remove docs that have been migrated to https://onnxruntime.ai/docs #6225
  2. Delete Dockerfile.centos_gpu. It is not used anywhere.
  3. Fix Linux CUDA 10.2 build error caused by glibc upgrade

Motivation and Context

  • Why is this change required? What problem does it solve?
  • If it fixes an open issue, please link to the issue here.

@snnn snnn requested a review from a team as a code owner February 6, 2021 07:55
@jywu-msft
Copy link
Member

jywu-msft commented Feb 9, 2021

I'm worried about removing cudnn_home option.
on some platforms (e.g. Nvidia JetPack), they are pre-installed locations and cuda_home/cudnn_home are not the same.
the user would have to move cudnn libraries to cuda location (which may not be possible for all cases)

Copy link
Member

@jywu-msft jywu-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm worried about removing cudnn_home build option and how it could break some user's scenarios.

@snnn
Copy link
Contributor Author

snnn commented Feb 9, 2021

I'm worried about removing cudnn_home option.
on some platforms (e.g. Nvidia JetPack), they are pre-installed locations and cuda_home/cudnn_home are not the same.
the user would have to move cudnn libraries to cuda location (which may not be possible for all cases)

i'm worried about removing cudnn_home build option and how it could break some user's scenarios.

Reverted.

@jywu-msft jywu-msft dismissed their stale review February 9, 2021 05:51

updated.

@snnn snnn merged commit 0b89f93 into master Feb 9, 2021
@snnn snnn deleted the snnn/cuda branch February 9, 2021 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants