Enable type reduction for ConstantOfShape CPU kernel. #6594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuslepukhin
reviewed
Feb 8, 2021
| // type list type containing the given types | ||
| // Note: this is useful for passing TypeLists to macros which don't accept the | ||
| // comma-separated template arguments | ||
| #define ORT_TYPE_LIST(...) ::onnxruntime::TypeList<__VA_ARGS__> |
Member
There was a problem hiding this comment.
(... [](start = 21, length = 4)
Is empty typelist OK? #Resolved
Contributor
Author
There was a problem hiding this comment.
skottmckay
reviewed
Feb 10, 2021
| KernelDefBuilder() | ||
| .TypeConstraint("T1", DataTypeImpl::GetTensorType<int64_t>()) | ||
| .TypeConstraint("T2", BuildKernelDefConstraintsFunctorFromTypeList<EnabledOutputTypes>{}()), | ||
| ConstantOfShape); |
Contributor
There was a problem hiding this comment.
Needs update to pass full and enabled types #Resolved
skottmckay
reviewed
Feb 10, 2021
| default: | ||
| ORT_THROW("Unsupported value attribute datatype: ", tensor_type); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Is it better to use a dispatcher here given otherwise you're defining code for all types even if they're disabled?
Contributor
Author
There was a problem hiding this comment.
tried using a dispatcher but wasn't able to match the binary size of the switch version when all types are enabled
In reply to: 573371802 [](ancestors = 573371802)
…f_shape_type_reduction
This reverts commit c8ad373.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable type reduction for ConstantOfShape CPU kernel.
Motivation and Context
Enable potential binary size decrease when limiting enabled types.